Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gen_cluster spill tests #758

Merged

Conversation

pentschev
Copy link
Member

The way coroutines are handled in Distributed test with gen_cluster was
changed in dask/distributed#5446, breaking the
two tests that still relied on gen_cluster. Since we don't encourage
using using coroutines/yield, there's really little reason to keep those
tests.

The way coroutines are handled in Distributed test with gen_cluster was
changed in dask/distributed#5446, breaking the
two tests that still relied on gen_cluster. Since we don't encourage
using using coroutines/yield, there's really little reason to keep those
tests.
@pentschev pentschev requested a review from a team as a code owner October 22, 2021 12:53
@github-actions github-actions bot added the python python code needed label Oct 22, 2021
@pentschev pentschev added 3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change labels Oct 22, 2021
@pentschev pentschev mentioned this pull request Oct 22, 2021
3 tasks
Copy link
Member

@quasiben quasiben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pentschev looks like the tests you are removing were already covered by test_cudf_cluster_device_spill

@quasiben
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 36a0251 into rapidsai:branch-21.12 Oct 22, 2021
@pentschev
Copy link
Member Author

Yes, that's right, we have other tests for checking that, but we were redundant on testing with gen_cluster which doesn't seem necessary to me in Dask-CUDA. Thanks for the review @quasiben !

@pentschev pentschev deleted the remove-gen-cluster-spill-tests branch October 22, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants